Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: KBC ignore, pull command #2136

Merged
merged 11 commits into from
Nov 19, 2024
Merged

feat: KBC ignore, pull command #2136

merged 11 commits into from
Nov 19, 2024

Conversation

hosekpeter
Copy link
Contributor

@hosekpeter hosekpeter commented Nov 6, 2024 •
edited by jira bot
Loading

Jira: PSGO-902

Changes:

  • added a logic to ignore specific configurations
  • added unit, e2e tests

@hosekpeter hosekpeter changed the title Ph psgo 902 pull command feat: KBC ignore, pull command Nov 6, 2024
@hosekpeter hosekpeter added the CLI label Nov 7, 2024
@hosekpeter hosekpeter force-pushed the ph-PSGO-902_pull_command branch 5 times, most recently from 110fb9c to 5254772 Compare November 8, 2024 14:25
@hosekpeter hosekpeter force-pushed the ph-PSGO-902_pull_command branch from 5254772 to 4a82ab6 Compare November 8, 2024 15:33
@hosekpeter hosekpeter marked this pull request as ready for review November 11, 2024 08:10
Matovidlo
Matovidlo reviewed Nov 11, 2024
View reviewed changes
internal/pkg/state/registry/registry.go Outdated Show resolved Hide resolved
internal/pkg/state/registry/registry.go Outdated Show resolved Hide resolved
internal/pkg/state/registry/registry_test.go Outdated Show resolved Hide resolved
@hosekpeter hosekpeter force-pushed the ph-PSGO-902_pull_command branch from a4ca901 to 688c50d Compare November 12, 2024 07:59
@hosekpeter hosekpeter requested a review from Matovidlo November 12, 2024 08:24
Matovidlo
Matovidlo reviewed Nov 12, 2024
View reviewed changes
internal/pkg/project/ignore/file.go Outdated Show resolved Hide resolved
internal/pkg/project/ignore/ignore.go Outdated Show resolved Hide resolved
internal/pkg/state/registry/registry.go Outdated Show resolved Hide resolved
internal/pkg/state/registry/registry.go Outdated Show resolved Hide resolved
internal/pkg/state/registry/registry_test.go Outdated Show resolved Hide resolved
@hosekpeter hosekpeter requested a review from Matovidlo November 12, 2024 09:36
jachym-tousek-keboola
jachym-tousek-keboola requested changes Nov 12, 2024
View reviewed changes
internal/pkg/state/registry/registry.go Outdated Show resolved Hide resolved
pkg/lib/operation/project/sync/pull/operation.go Outdated Show resolved Hide resolved
pkg/lib/operation/project/sync/pull/operation.go Outdated Show resolved Hide resolved
internal/pkg/state/registry/registry.go Outdated Show resolved Hide resolved
@hosekpeter hosekpeter force-pushed the ph-PSGO-902_pull_command branch from ae0cdbe to 2d06024 Compare November 12, 2024 11:13
@hosekpeter hosekpeter merged commit 3823eed into main Nov 19, 2024
12 checks passed
@hosekpeter hosekpeter deleted the ph-PSGO-902_pull_command branch November 19, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jachym-tousek-keboola jachym-tousek-keboola jachym-tousek-keboola approved these changes

@Matovidlo Matovidlo Matovidlo approved these changes

Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hosekpeter @Matovidlo @jachym-tousek-keboola